Commit 0cf765fb authored by Jiapeng Chong's avatar Jiapeng Chong Committed by David S. Miller
Browse files

sfc: Use swap() instead of open coding it 



Clean the following coccicheck warning:

./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity
for swap().

./drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity
for swap().

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ccd21ec5

drivers/net/ethernet/sfc/efx_channels.c

+4 −10
Original line number Diff line number Diff line
@@ -819,11 +819,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) 
	old_txq_entries = efx->txq_entries;

	efx->rxq_entries = rxq_entries;

	efx->txq_entries = txq_entries;

	for (i = 0; i < efx->n_channels; i++) {

		channel = efx->channel[i];

		efx->channel[i] = other_channel[i];

		other_channel[i] = channel;

	}

	for (i = 0; i < efx->n_channels; i++)

		swap(efx->channel[i], other_channel[i]);



	/* Restart buffer table allocation */

	efx->next_buffer_table = next_buffer_table;
@@ -865,11 +862,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) 
	/* Swap back */

	efx->rxq_entries = old_rxq_entries;

	efx->txq_entries = old_txq_entries;

	for (i = 0; i < efx->n_channels; i++) {

		channel = efx->channel[i];

		efx->channel[i] = other_channel[i];

		other_channel[i] = channel;

	}

	for (i = 0; i < efx->n_channels; i++)

		swap(efx->channel[i], other_channel[i]);

	goto out;

}