Commit 0cf38586 authored by Dejin Zheng's avatar Dejin Zheng Committed by Marc Kleine-Budde
Browse files

can: ti_hecc: convert to devm_platform_ioremap_resource_byname() 



Use the function devm_platform_ioremap_resource_byname() to simplify
source code which calls the functions platform_get_resource_byname()
and devm_ioremap_resource(). Remove also a few error messages which
became unnecessary with this software refactoring.

Signed-off-by: default avatarDejin Zheng <zhengdejin5@gmail.com>
Link: https://lore.kernel.org/r/20200420132207.8536-1-zhengdejin5@gmail.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 71ef9dfd

drivers/net/can/ti_hecc.c

+5 −22
Original line number Diff line number Diff line
@@ -857,7 +857,7 @@ static int ti_hecc_probe(struct platform_device *pdev) 
	struct net_device *ndev = (struct net_device *)0;

	struct ti_hecc_priv *priv;

	struct device_node *np = pdev->dev.of_node;

	struct resource *res, *irq;

	struct resource *irq;

	struct regulator *reg_xceiver;

	int err = -ENODEV;
@@ -878,39 +878,22 @@ static int ti_hecc_probe(struct platform_device *pdev) 
	priv = netdev_priv(ndev);



	/* handle hecc memory */

	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hecc");

	if (!res) {

		dev_err(&pdev->dev, "can't get IORESOURCE_MEM hecc\n");

		return -EINVAL;

	}



	priv->base = devm_ioremap_resource(&pdev->dev, res);

	priv->base = devm_platform_ioremap_resource_byname(pdev, "hecc");

	if (IS_ERR(priv->base)) {

		dev_err(&pdev->dev, "hecc ioremap failed\n");

		return PTR_ERR(priv->base);

	}



	/* handle hecc-ram memory */

	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hecc-ram");

	if (!res) {

		dev_err(&pdev->dev, "can't get IORESOURCE_MEM hecc-ram\n");

		return -EINVAL;

	}



	priv->hecc_ram = devm_ioremap_resource(&pdev->dev, res);

	priv->hecc_ram = devm_platform_ioremap_resource_byname(pdev,

							       "hecc-ram");

	if (IS_ERR(priv->hecc_ram)) {

		dev_err(&pdev->dev, "hecc-ram ioremap failed\n");

		return PTR_ERR(priv->hecc_ram);

	}



	/* handle mbx memory */

	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mbx");

	if (!res) {

		dev_err(&pdev->dev, "can't get IORESOURCE_MEM mbx\n");

		return -EINVAL;

	}



	priv->mbx = devm_ioremap_resource(&pdev->dev, res);

	priv->mbx = devm_platform_ioremap_resource_byname(pdev, "mbx");

	if (IS_ERR(priv->mbx)) {

		dev_err(&pdev->dev, "mbx ioremap failed\n");

		return PTR_ERR(priv->mbx);