Commit 0ce779a9 authored by Miaohe Lin's avatar Miaohe Lin Committed by David S. Miller
Browse files

net: Avoid unnecessary inet_addr_type() call when addr is INADDR_ANY 



We can avoid unnecessary inet_addr_type() call by check addr against
INADDR_ANY first.

Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0316a211

net/ipv4/ping.c

+2 −2
Original line number Diff line number Diff line
@@ -310,10 +310,10 @@ static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk, 
		pr_debug("ping_check_bind_addr(sk=%p,addr=%pI4,port=%d)\n",

			 sk, &addr->sin_addr.s_addr, ntohs(addr->sin_port));



		chk_addr_ret = inet_addr_type(net, addr->sin_addr.s_addr);



		if (addr->sin_addr.s_addr == htonl(INADDR_ANY))

			chk_addr_ret = RTN_LOCAL;

		else

			chk_addr_ret = inet_addr_type(net, addr->sin_addr.s_addr);



		if ((!inet_can_nonlocal_bind(net, isk) &&

		     chk_addr_ret != RTN_LOCAL) ||