Commit 0cd142b4 authored by Yi Yang's avatar Yi Yang Committed by Greg Kroah-Hartman
Browse files

usb: fotg210-udc: fix potential memory leak in fotg210_udc_probe() 



In fotg210_udc_probe(), if devm_clk_get() or clk_prepare_enable()
fails, 'fotg210' will not be freed, which will lead to a memory leak.
Fix it by moving kfree() to a proper location.

In addition，we can use "return -ENOMEM" instead of "goto err"
to simplify the code.

Fixes: 718a38d0 ("fotg210-udc: Handle PCLK")
Reviewed-by: default avatarAndrzej Pietrasiewicz <andrzej.p@collabora.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarYi Yang <yiyang13@huawei.com>
Link: https://lore.kernel.org/r/20221202012126.246953-1-yiyang13@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 59d54aa0

drivers/usb/fotg210/fotg210-udc.c

+3 −6
Original line number Diff line number Diff line
@@ -1163,12 +1163,10 @@ int fotg210_udc_probe(struct platform_device *pdev) 
		return -ENODEV;

	}



	ret = -ENOMEM;



	/* initialize udc */

	fotg210 = kzalloc(sizeof(struct fotg210_udc), GFP_KERNEL);

	if (fotg210 == NULL)

		goto err;

		return -ENOMEM;



	fotg210->dev = dev;
@@ -1178,7 +1176,7 @@ int fotg210_udc_probe(struct platform_device *pdev) 
		ret = clk_prepare_enable(fotg210->pclk);

		if (ret) {

			dev_err(dev, "failed to enable PCLK\n");

			return ret;

			goto err;

		}

	} else if (PTR_ERR(fotg210->pclk) == -EPROBE_DEFER) {

		/*
@@ -1302,8 +1300,7 @@ int fotg210_udc_probe(struct platform_device *pdev) 
	if (!IS_ERR(fotg210->pclk))

		clk_disable_unprepare(fotg210->pclk);



	kfree(fotg210);



err:

	kfree(fotg210);

	return ret;

}