Commit 0c90547b authored by Chris Metcalf's avatar Chris Metcalf
Browse files

arch/tile: use new generic {enable,disable}_percpu_irq() routines 



We provided very similar routines internally, but now we can hook
into the generic framework by supplying our routines as function
pointers in the irq_chip structure instead.

Signed-off-by: default avatarChris Metcalf <cmetcalf@tilera.com>
parent 781a5e92

arch/tile/include/asm/irq.h

+0 −10
Original line number Diff line number Diff line
@@ -74,16 +74,6 @@ enum { 
 */

void tile_irq_activate(unsigned int irq, int tile_irq_type);



/*

 * For onboard, non-PCI (e.g. TILE_IRQ_PERCPU) devices, drivers know

 * how to use enable/disable_percpu_irq() to manage interrupts on each

 * core.  We can't use the generic enable/disable_irq() because they

 * use a single reference count per irq, rather than per cpu per irq.

 */

void enable_percpu_irq(unsigned int irq);

void disable_percpu_irq(unsigned int irq);





void setup_irq_regs(void);



#endif /* _ASM_TILE_IRQ_H */

arch/tile/kernel/irq.c

+8 −8
Original line number Diff line number Diff line
@@ -152,14 +152,13 @@ void tile_dev_intr(struct pt_regs *regs, int intnum) 
 * Remove an irq from the disabled mask.  If we're in an interrupt

 * context, defer enabling the HW interrupt until we leave.

 */

void enable_percpu_irq(unsigned int irq)

static void tile_irq_chip_enable(struct irq_data *d)

{

	get_cpu_var(irq_disable_mask) &= ~(1UL << irq);

	get_cpu_var(irq_disable_mask) &= ~(1UL << d->irq);

	if (__get_cpu_var(irq_depth) == 0)

		unmask_irqs(1UL << irq);

		unmask_irqs(1UL << d->irq);

	put_cpu_var(irq_disable_mask);

}

EXPORT_SYMBOL(enable_percpu_irq);



/*

 * Add an irq to the disabled mask.  We disable the HW interrupt
@@ -167,13 +166,12 @@ EXPORT_SYMBOL(enable_percpu_irq); 
 * in an interrupt context, the return path is careful to avoid

 * unmasking a newly disabled interrupt.

 */

void disable_percpu_irq(unsigned int irq)

static void tile_irq_chip_disable(struct irq_data *d)

{

	get_cpu_var(irq_disable_mask) |= (1UL << irq);

	mask_irqs(1UL << irq);

	get_cpu_var(irq_disable_mask) |= (1UL << d->irq);

	mask_irqs(1UL << d->irq);

	put_cpu_var(irq_disable_mask);

}

EXPORT_SYMBOL(disable_percpu_irq);



/* Mask an interrupt. */

static void tile_irq_chip_mask(struct irq_data *d)
@@ -209,6 +207,8 @@ static void tile_irq_chip_eoi(struct irq_data *d) 


static struct irq_chip tile_irq_chip = {

	.name = "tile_irq_chip",

	.irq_enable = tile_irq_chip_enable,

	.irq_disable = tile_irq_chip_disable,

	.irq_ack = tile_irq_chip_ack,

	.irq_eoi = tile_irq_chip_eoi,

	.irq_mask = tile_irq_chip_mask,

drivers/net/ethernet/tile/tilepro.c

+2 −2
Original line number Diff line number Diff line
@@ -926,7 +926,7 @@ static int tile_net_poll(struct napi_struct *napi, int budget) 
		goto done;



	/* Re-enable the ingress interrupt. */

	enable_percpu_irq(priv->intr_id);

	enable_percpu_irq(priv->intr_id, 0);



	/* HACK: Avoid the "rotting packet" problem (see above). */

	if (qup->__packet_receive_read !=
@@ -1296,7 +1296,7 @@ static void tile_net_open_enable(void *dev_ptr) 
	info->napi_enabled = true;



	/* Enable the ingress interrupt. */

	enable_percpu_irq(priv->intr_id);

	enable_percpu_irq(priv->intr_id, 0);

}