Commit 0c85c54b authored by Andrea Parri (Microsoft)'s avatar Andrea Parri (Microsoft) Committed by Wei Liu
Browse files

Drivers: hv: vmbus: Drop error message when 'No request id available' 



Running out of request IDs on a channel essentially produces the same
effect as running out of space in the ring buffer, in that -EAGAIN is
returned.  The error message in hv_ringbuffer_write() should either be
dropped (since we don't output a message when the ring buffer is full)
or be made conditional/debug-only.

Suggested-by: default avatarMichael Kelley <mikelley@microsoft.com>
Signed-off-by: default avatarAndrea Parri (Microsoft) <parri.andrea@gmail.com>
Fixes: e8b7db38 ("Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening")
Link: https://lore.kernel.org/r/20210301191348.196485-1-parri.andrea@gmail.com


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
parent a620bbaa

drivers/hv/ring_buffer.c

+0 −1
Original line number Diff line number Diff line
@@ -313,7 +313,6 @@ int hv_ringbuffer_write(struct vmbus_channel *channel, 
		rqst_id = vmbus_next_request_id(&channel->requestor, requestid);

		if (rqst_id == VMBUS_RQST_ERROR) {

			spin_unlock_irqrestore(&outring_info->ring_lock, flags);

			pr_err("No request id available\n");

			return -EAGAIN;

		}

	}