Commit 0c85a7e8 authored by Aditya Pakki's avatar Aditya Pakki Committed by David S. Miller
Browse files

net/rds: Avoid potential use after free in rds_send_remove_from_sock 



In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource
is freed and later under spinlock, causing potential use-after-free.
Set the free pointer to NULL to avoid undefined behavior.

Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5219d601

net/rds/message.c

+1 −0
Original line number Diff line number Diff line
@@ -180,6 +180,7 @@ void rds_message_put(struct rds_message *rm) 
		rds_message_purge(rm);



		kfree(rm);

		rm = NULL;

	}

}

EXPORT_SYMBOL_GPL(rds_message_put);

net/rds/send.c

+1 −1
Original line number Diff line number Diff line
@@ -665,7 +665,7 @@ static void rds_send_remove_from_sock(struct list_head *messages, int status) 
unlock_and_drop:

		spin_unlock_irqrestore(&rm->m_rs_lock, flags);

		rds_message_put(rm);

		if (was_on_sock)

		if (was_on_sock && rm)

			rds_message_put(rm);

	}