Commit 0c441cb6 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Call i915_sw_fence_fini on request cleanup 



As i915_requests are put into an RCU-freelist, they may get reused
before debugobjects notice them as being freed. On cleanup, explicitly
call i915_sw_fence_fini() so that the debugobject is properly tracked.

Reported-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
Fixes: b7404c7e ("drm/i915: Bump ready tasks ahead of busywaits")
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190411122445.20060-1-chris@chris-wilson.co.uk
parent aefa95ba

drivers/gpu/drm/i915/i915_request.c

+1 −0
Original line number Diff line number Diff line
@@ -101,6 +101,7 @@ static void i915_fence_release(struct dma_fence *fence) 
	 * caught trying to reuse dead objects.

	 */

	i915_sw_fence_fini(&rq->submit);

	i915_sw_fence_fini(&rq->semaphore);



	kmem_cache_free(global.slab_requests, rq);

}