Commit 0c4214e1 authored Oct 15, 2021 by Lukasz Cieplicki Committed by Zheng Zengkai Oct 15, 2021

i40e: Add additional info to PHY type error

stable inclusion
from stable-5.10.56
commit 75ebe1d355b5b179568009ef35042d3c7be7ee00
bugzilla: 176004 https://gitee.com/openeuler/kernel/issues/I4DYZ4

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=75ebe1d355b5b179568009ef35042d3c7be7ee00



--------------------------------

commit dc614c46 upstream.

In case of PHY type error occurs, the message was too generic.
Add additional info to PHY type error indicating that it can be
wrong cable connected.

Fixes: 124ed15b ("i40e: Add dual speed module support")
Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Chen Jun <chenjun102@huawei.com>
Acked-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Chen Jun <chenjun102@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>

parent aeac6286

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -980,7 +980,7 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,
		default:
		/* if we got here and link is up something bad is afoot */
		netdev_info(netdev,
		"WARNING: Link is up but PHY type 0x%x is not recognized.\n",
		"WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n",
		hw_link_info->phy_type);
		}