Commit 0c3f7b38 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf inject: Call dso__put() even if dso->hit is set 



Otherwise it'll leak the refcount for the DSO.  As dso__put() can
handle a NULL dso pointer, we can just call it unconditionally.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210524225051.1190486-1-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent a92bf335

tools/perf/builtin-inject.c

+2 −2
Original line number Diff line number Diff line
@@ -383,8 +383,8 @@ static int perf_event__repipe_buildid_mmap(struct perf_tool *tool, 
	if (dso && !dso->hit) {

		dso->hit = 1;

		dso__inject_build_id(dso, tool, machine, sample->cpumode, 0);

		dso__put(dso);

	}

	dso__put(dso);



	return perf_event__repipe(tool, event, sample, machine);

}
@@ -447,8 +447,8 @@ static int perf_event__repipe_buildid_mmap2(struct perf_tool *tool, 
		dso->hit = 1;

		dso__inject_build_id(dso, tool, machine, sample->cpumode,

				     event->mmap2.flags);

		dso__put(dso);

	}

	dso__put(dso);



	perf_event__repipe(tool, event, sample, machine);