Commit 0c14d313 authored by Frieder Schrempf's avatar Frieder Schrempf Committed by Neil Armstrong
Browse files

drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec 

According to the documentation [1] the proper enable flow is:

1. Enable DSI link and keep data lanes in LP-11 (stop state)
2. Disable stop state to bring data lanes into HS mode

Currently we do this all at once within enable(), which doesn't
allow to meet the requirements of some downstream bridges.

To fix this we now enable the DSI in pre_enable() and force it
into stop state using the FORCE_STOP_STATE bit in the ESCMODE
register until enable() is called where we reset the bit.

We currently do this only for i.MX8M as Exynos uses a different
init flow where samsung_dsim_init() is called from
samsung_dsim_host_transfer().

[1] https://docs.kernel.org/gpu/drm-kms-helpers.html#mipi-dsi-bridge-operation



Signed-off-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> #TQMa8MxML/MBa8Mx
Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230503163313.2640898-2-frieder@fris.de
parent abd686b8

drivers/gpu/drm/bridge/samsung-dsim.c

+23 −2
Original line number Diff line number Diff line
@@ -866,6 +866,10 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi) 
	reg = samsung_dsim_read(dsi, DSIM_ESCMODE_REG);

	reg &= ~DSIM_STOP_STATE_CNT_MASK;

	reg |= DSIM_STOP_STATE_CNT(driver_data->reg_values[STOP_STATE_CNT]);



	if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type))

		reg |= DSIM_FORCE_STOP_STATE;



	samsung_dsim_write(dsi, DSIM_ESCMODE_REG, reg);



	reg = DSIM_BTA_TIMEOUT(0xff) | DSIM_LPDR_TIMEOUT(0xffff);
@@ -1347,6 +1351,9 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, 
		ret = samsung_dsim_init(dsi);

		if (ret)

			return;



		samsung_dsim_set_display_mode(dsi);

		samsung_dsim_set_display_enable(dsi, true);

	}

}
@@ -1354,9 +1361,16 @@ static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, 
				       struct drm_bridge_state *old_bridge_state)

{

	struct samsung_dsim *dsi = bridge_to_dsi(bridge);

	u32 reg;



	if (samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) {

		samsung_dsim_set_display_mode(dsi);

		samsung_dsim_set_display_enable(dsi, true);

	} else {

		reg = samsung_dsim_read(dsi, DSIM_ESCMODE_REG);

		reg &= ~DSIM_FORCE_STOP_STATE;

		samsung_dsim_write(dsi, DSIM_ESCMODE_REG, reg);

	}



	dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;

}
@@ -1365,10 +1379,17 @@ static void samsung_dsim_atomic_disable(struct drm_bridge *bridge, 
					struct drm_bridge_state *old_bridge_state)

{

	struct samsung_dsim *dsi = bridge_to_dsi(bridge);

	u32 reg;



	if (!(dsi->state & DSIM_STATE_ENABLED))

		return;



	if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) {

		reg = samsung_dsim_read(dsi, DSIM_ESCMODE_REG);

		reg |= DSIM_FORCE_STOP_STATE;

		samsung_dsim_write(dsi, DSIM_ESCMODE_REG, reg);

	}



	dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE;

}