Unverified Commit 0c0206dc authored by Xinghui Li's avatar Xinghui Li Committed by Krzysztof Wilczyński
Browse files

PCI: vmd: Fix uninitialized variable usage in vmd_enable_domain() 

The ret variable in the vmd_enable_domain() function was used
uninitialized when printing a warning message upon failure of
the pci_reset_bus() function.

Thus, fix the issue by assigning ret with the value returned from
pci_reset_bus() before referencing it in the warning message.

This was detected by Smatch:

  drivers/pci/controller/vmd.c:931 vmd_enable_domain() error: uninitialized symbol 'ret'.

[kwilczynski: drop the second patch from the series, add missing reported
by tag, commit log]
Fixes: 0a584655 ("PCI: vmd: Fix secondary bus reset for Intel bridges")
Link: https://lore.kernel.org/all/202305270219.B96IiIfv-lkp@intel.com
Link: https://lore.kernel.org/linux-pci/20230420094332.1507900-2-korantwork@gmail.com


Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarXinghui Li <korantli@tencent.com>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarNirmal Patel <nirmal.patel@linux.intel.com>
parent b61cf04c

drivers/pci/controller/vmd.c

+2 −1
Original line number Diff line number Diff line
@@ -927,7 +927,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features) 
		if (!list_empty(&child->devices)) {

			dev = list_first_entry(&child->devices,

					       struct pci_dev, bus_list);

			if (pci_reset_bus(dev))

			ret = pci_reset_bus(dev);

			if (ret)

				pci_warn(dev, "can't reset device: %d\n", ret);



			break;