Commit 0bedd3d0 authored by Lang Cheng's avatar Lang Cheng Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Remove unused parameter udata 

The old version of ib_umem_get() need these udata as a parameter but now
they are unnecessary.

Fixes: c320e527 ("IB: Allow calls to ib_umem_get from kernel ULPs")
Link: https://lore.kernel.org/r/1620807142-39157-4-git-send-email-liweihang@huawei.com


Signed-off-by: default avatarLang Cheng <chenglang@huawei.com>
Signed-off-by: default avatarWeihang Li <liweihang@huawei.com>
Acked-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent aca496fb

drivers/infiniband/hw/mlx5/cq.c

+1 −1
Original line number Diff line number Diff line
@@ -750,7 +750,7 @@ static int create_cq_user(struct mlx5_ib_dev *dev, struct ib_udata *udata, 
		goto err_umem;

	}



	err = mlx5_ib_db_map_user(context, udata, ucmd.db_addr, &cq->db);

	err = mlx5_ib_db_map_user(context, ucmd.db_addr, &cq->db);

	if (err)

		goto err_umem;

drivers/infiniband/hw/mlx5/doorbell.c

+1 −2
Original line number Diff line number Diff line
@@ -43,8 +43,7 @@ struct mlx5_ib_user_db_page { 
	int			refcnt;

};



int mlx5_ib_db_map_user(struct mlx5_ib_ucontext *context,

			struct ib_udata *udata, unsigned long virt,

int mlx5_ib_db_map_user(struct mlx5_ib_ucontext *context, unsigned long virt,

			struct mlx5_db *db)

{

	struct mlx5_ib_user_db_page *page;

drivers/infiniband/hw/mlx5/mlx5_ib.h

+1 −3
Original line number Diff line number Diff line
@@ -1198,8 +1198,7 @@ to_mmmap(struct rdma_user_mmap_entry *rdma_entry) 
		struct mlx5_user_mmap_entry, rdma_entry);

}



int mlx5_ib_db_map_user(struct mlx5_ib_ucontext *context,

			struct ib_udata *udata, unsigned long virt,

int mlx5_ib_db_map_user(struct mlx5_ib_ucontext *context, unsigned long virt,

			struct mlx5_db *db);

void mlx5_ib_db_unmap_user(struct mlx5_ib_ucontext *context, struct mlx5_db *db);

void __mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 qpn, struct mlx5_ib_srq *srq);
@@ -1265,7 +1264,6 @@ int mlx5_ib_update_xlt(struct mlx5_ib_mr *mr, u64 idx, int npages, 
		       int page_shift, int flags);

int mlx5_ib_update_mr_pas(struct mlx5_ib_mr *mr, unsigned int flags);

struct mlx5_ib_mr *mlx5_ib_alloc_implicit_mr(struct mlx5_ib_pd *pd,

					     struct ib_udata *udata,

					     int access_flags);

void mlx5_ib_free_implicit_mr(struct mlx5_ib_mr *mr);

void mlx5_ib_free_odp_mr(struct mlx5_ib_mr *mr);

drivers/infiniband/hw/mlx5/mr.c

+1 −1
Original line number Diff line number Diff line
@@ -1510,7 +1510,7 @@ static struct ib_mr *create_user_odp_mr(struct ib_pd *pd, u64 start, u64 length, 
		if (!(dev->odp_caps.general_caps & IB_ODP_SUPPORT_IMPLICIT))

			return ERR_PTR(-EINVAL);



		mr = mlx5_ib_alloc_implicit_mr(to_mpd(pd), udata, access_flags);

		mr = mlx5_ib_alloc_implicit_mr(to_mpd(pd), access_flags);

		if (IS_ERR(mr))

			return ERR_CAST(mr);

		return &mr->ibmr;

drivers/infiniband/hw/mlx5/odp.c

+0 −1
Original line number Diff line number Diff line
@@ -478,7 +478,6 @@ static struct mlx5_ib_mr *implicit_get_child_mr(struct mlx5_ib_mr *imr, 
}



struct mlx5_ib_mr *mlx5_ib_alloc_implicit_mr(struct mlx5_ib_pd *pd,

					     struct ib_udata *udata,

					     int access_flags)

{

	struct mlx5_ib_dev *dev = to_mdev(pd->ibpd.device);