Commit 0bcee119 authored by Enric Balletbo i Serra's avatar Enric Balletbo i Serra Committed by Dmitry Torokhov
Browse files

Input: cros_ec_keyb - use cros_ec_cmd_xfer_status helper 



This patch makes use of cros_ec_cmd_xfer_status() instead of
cros_ec_cmd_xfer(). In this case there is no advantage of doing this
apart from that we want to make cros_ec_cmd_xfer() a private function
for the EC protocol and let people only use the
cros_ec_cmd_xfer_status() to return Linux standard error codes.

Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200414210434.1534982-1-enric.balletbo@collabora.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 3f8f7705

drivers/input/keyboard/cros_ec_keyb.c

+5 −9
Original line number Diff line number Diff line
@@ -347,18 +347,14 @@ static int cros_ec_keyb_info(struct cros_ec_device *ec_dev, 
	params->info_type = info_type;

	params->event_type = event_type;



	ret = cros_ec_cmd_xfer(ec_dev, msg);

	if (ret < 0) {

		dev_warn(ec_dev->dev, "Transfer error %d/%d: %d\n",

			 (int)info_type, (int)event_type, ret);

	} else if (msg->result == EC_RES_INVALID_VERSION) {

	ret = cros_ec_cmd_xfer_status(ec_dev, msg);

	if (ret == -ENOTSUPP) {

		/* With older ECs we just return 0 for everything */

		memset(result, 0, result_size);

		ret = 0;

	} else if (msg->result != EC_RES_SUCCESS) {

		dev_warn(ec_dev->dev, "Error getting info %d/%d: %d\n",

			 (int)info_type, (int)event_type, msg->result);

		ret = -EPROTO;

	} else if (ret < 0) {

		dev_warn(ec_dev->dev, "Transfer error %d/%d: %d\n",

			 (int)info_type, (int)event_type, ret);

	} else if (ret != result_size) {

		dev_warn(ec_dev->dev, "Wrong size %d/%d: %d != %zu\n",

			 (int)info_type, (int)event_type,