Unverified Commit 0bae5687 authored by Hsin-Yi Wang's avatar Hsin-Yi Wang Committed by Robert Foss
Browse files

drm/bridge: anx7625: Fix edid_read break case in sp_tx_edid_read() 



edid_read() was assumed to return 0 on success. After commit
7f16d0f3("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()"),
the function will return > 0 for successful case, representing the i2c
read bytes. Otherwise -EIO on failure cases. Update the g_edid_break
break condition accordingly.

Fixes: 7f16d0f3("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()")
Signed-off-by: default avatarHsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: default avatarRobert Foss <robert.foss@linaro.org>
Reviewed-by: default avatarXin Ji <xji@analogixsemi.com>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211118193002.407168-1-hsinyi@chromium.org
parent 7057474c

drivers/gpu/drm/bridge/analogix/anx7625.c

+2 −2
Original line number Diff line number Diff line
@@ -850,7 +850,7 @@ static int sp_tx_edid_read(struct anx7625_data *ctx, 
	int count, blocks_num;

	u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];

	u8 i, j;

	u8 g_edid_break = 0;

	int g_edid_break = 0;

	int ret;

	struct device *dev = &ctx->client->dev;
@@ -881,7 +881,7 @@ static int sp_tx_edid_read(struct anx7625_data *ctx, 
				g_edid_break = edid_read(ctx, offset,

							 pblock_buf);



				if (g_edid_break)

				if (g_edid_break < 0)

					break;



				memcpy(&pedid_blocks_buf[offset],