Commit 0b75a1b1 authored Mar 31, 2023 by Johannes Berg

wifi: mac80211: flush queues on STA removal



When we remove a station, we first make it unreachable,
then we (must) remove its keys, and then remove the
station itself. Depending on the hardware design, if
we have hardware crypto at all, frames still sitting
on hardware queues may then be transmitted without a
valid key, possibly unencrypted or with a fixed key.

Fix this by flushing the queues when removing stations
so this cannot happen.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 2c9abe65

net/mac80211/sta_info.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -1294,6 +1294,14 @@ static void __sta_info_destroy_part2(struct sta_info *sta)
		WARN_ON_ONCE(ret);
		}

		/* Flush queues before removing keys, as that might remove them
		* from hardware, and then depending on the offload method, any
		* frames sitting on hardware queues might be sent out without
		* any encryption at all.
		*/
		if (local->ops->set_key)
		ieee80211_flush_queues(local, sta->sdata, false);

		/* now keys can no longer be reached */
		ieee80211_free_sta_keys(local, sta);