Commit 0b484c91 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

tcp: Fix a data-race around sysctl_tcp_rfc1337. 



While reading sysctl_tcp_rfc1337, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4e08ed41

net/ipv4/tcp_minisocks.c

+1 −1
Original line number Diff line number Diff line
@@ -173,7 +173,7 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, 
			 * Oh well... nobody has a sufficient solution to this

			 * protocol bug yet.

			 */

			if (twsk_net(tw)->ipv4.sysctl_tcp_rfc1337 == 0) {

			if (!READ_ONCE(twsk_net(tw)->ipv4.sysctl_tcp_rfc1337)) {

kill:

				inet_twsk_deschedule_put(tw);

				return TCP_TW_SUCCESS;