Commit 0b217d3d authored by Lijun Pan's avatar Lijun Pan Committed by David S. Miller
Browse files

ibmvnic: fix kernel build warning in strncpy 



drivers/net/ethernet/ibm/ibmvnic.c: In function ‘handle_vpd_rsp’:
drivers/net/ethernet/ibm/ibmvnic.c:4393:3: warning: ‘strncpy’ output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation]
 4393 |   strncpy((char *)adapter->fw_version, "N/A", 3 * sizeof(char));
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: default avatarLijun Pan <lijunp213@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2227ec7b

drivers/net/ethernet/ibm/ibmvnic.c

+1 −1
Original line number Diff line number Diff line
@@ -4385,7 +4385,7 @@ static void handle_vpd_rsp(union ibmvnic_crq *crq, 


complete:

	if (adapter->fw_version[0] == '\0')

		strncpy((char *)adapter->fw_version, "N/A", 3 * sizeof(char));

		strscpy((char *)adapter->fw_version, "N/A", sizeof(adapter->fw_version));

	complete(&adapter->fw_done);

}