Commit 0ae8ef67 authored Mar 29, 2021 by Luiz Augusto von Dentz Committed by Marcel Holtmann Apr 02, 2021

Bluetooth: SMP: Fix variable dereferenced before check 'conn'



This fixes kbuild findings:

smatch warnings:
net/bluetooth/smp.c:1633 smp_user_confirm_reply() warn: variable
dereferenced before check 'conn' (see line 1631)

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent 06752d16

net/bluetooth/smp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1628,11 +1628,11 @@ int smp_user_confirm_reply(struct hci_conn *hcon, u16 mgmt_op, __le32 passkey)
		u32 value;
		int err;

		bt_dev_dbg(conn->hcon->hdev, "");

		if (!conn)
		return -ENOTCONN;

		bt_dev_dbg(conn->hcon->hdev, "");

		chan = conn->smp;
		if (!chan)
		return -ENOTCONN;