Commit 0add5c59 authored by Benjamin Poirier's avatar Benjamin Poirier Committed by Jakub Kicinski
Browse files

ipv4: Set offload_failed flag in fibmatch results 



Due to a small omission, the offload_failed flag is missing from ipv4
fibmatch results. Make sure it is set correctly.

The issue can be witnessed using the following commands:
echo "1 1" > /sys/bus/netdevsim/new_device
ip link add dummy1 up type dummy
ip route add 192.0.2.0/24 dev dummy1
echo 1 > /sys/kernel/debug/netdevsim/netdevsim1/fib/fail_route_offload
ip route add 198.51.100.0/24 dev dummy1
ip route
	# 192.168.15.0/24 has rt_trap
	# 198.51.100.0/24 has rt_offload_failed
ip route get 192.168.15.1 fibmatch
	# Result has rt_trap
ip route get 198.51.100.1 fibmatch
	# Result differs from the route shown by `ip route`, it is missing
	# rt_offload_failed
ip link del dev dummy1
echo 1 > /sys/bus/netdevsim/del_device

Fixes: 36c5100e ("IPv4: Add "offload failed" indication to routes")
Signed-off-by: default avatarBenjamin Poirier <bpoirier@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20230926182730.231208-1-bpoirier@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 72897b29

net/ipv4/route.c

+2 −0
Original line number Diff line number Diff line
@@ -3417,6 +3417,8 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh, 
				    fa->fa_type == fri.type) {

					fri.offload = READ_ONCE(fa->offload);

					fri.trap = READ_ONCE(fa->trap);

					fri.offload_failed =

						READ_ONCE(fa->offload_failed);

					break;

				}

			}