Commit 0ad7e3ed authored by Siddharth Gupta's avatar Siddharth Gupta Committed by Bjorn Andersson
Browse files

remoteproc: qcom: q6v5: Set q6 state to offline on receiving wdog irq 



Due to firmware bugs on the Q6 the hardware watchdog irq can be triggered
multiple times. As the remoteproc framework schedules work items for the
recovery process, if the other threads do not get a chance to run before
recovery is completed the proceeding threads will see the state of the
remoteproc as running and kill the remoteproc while it is running. This
can result in various SMMU and NOC errors. This change sets the state of
the remoteproc to offline whenever a watchdog irq is received.

Signed-off-by: default avatarSiddharth Gupta <sidgup@codeaurora.org>
Signed-off-by: default avatarSibi Sankar <quic_sibis@quicinc.com>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/1657022900-2049-6-git-send-email-quic_sibis@quicinc.com
parent 7b6ece96

drivers/remoteproc/qcom_q6v5.c

+4 −0
Original line number Diff line number Diff line
@@ -112,6 +112,7 @@ static irqreturn_t q6v5_wdog_interrupt(int irq, void *data) 
	else

		dev_err(q6v5->dev, "watchdog without message\n");



	q6v5->running = false;

	rproc_report_crash(q6v5->rproc, RPROC_WATCHDOG);



	return IRQ_HANDLED;
@@ -123,6 +124,9 @@ static irqreturn_t q6v5_fatal_interrupt(int irq, void *data) 
	size_t len;

	char *msg;



	if (!q6v5->running)

		return IRQ_HANDLED;



	msg = qcom_smem_get(QCOM_SMEM_HOST_ANY, q6v5->crash_reason, &len);

	if (!IS_ERR(msg) && len > 0 && msg[0])

		dev_err(q6v5->dev, "fatal error received: %s\n", msg);