Commit 0ac72f90 authored by Bjorn Andersson's avatar Bjorn Andersson
Browse files

remoteproc: sysmon: Improve error messages 



Improve the style of a few of the error messages printed by the sysmon
implementation and fix the copy-pasted shutdown error in the send-event
function.

Tested-by: default avatarSteev Klimaszewski <steev@kali.org>
Reviewed-by: default avatarRishabh Bhatnagar <rishabhb@codeaurora.org>
Link: https://lore.kernel.org/r/20201122054135.802935-5-bjorn.andersson@linaro.org


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent ed5da808

drivers/remoteproc/qcom_sysmon.c

+6 −6
Original line number Diff line number Diff line
@@ -352,9 +352,9 @@ static bool ssctl_request_shutdown(struct qcom_sysmon *sysmon) 


	ret = qmi_txn_wait(&txn, 5 * HZ);

	if (ret < 0) {

		dev_err(sysmon->dev, "failed receiving QMI response\n");

		dev_err(sysmon->dev, "timeout waiting for shutdown response\n");

	} else if (resp.resp.result) {

		dev_err(sysmon->dev, "shutdown request failed\n");

		dev_err(sysmon->dev, "shutdown request rejected\n");

	} else {

		dev_dbg(sysmon->dev, "shutdown request completed\n");

		acked = true;
@@ -397,18 +397,18 @@ static void ssctl_send_event(struct qcom_sysmon *sysmon, 
			       SSCTL_SUBSYS_EVENT_REQ, 40,

			       ssctl_subsys_event_req_ei, &req);

	if (ret < 0) {

		dev_err(sysmon->dev, "failed to send shutdown request\n");

		dev_err(sysmon->dev, "failed to send subsystem event\n");

		qmi_txn_cancel(&txn);

		return;

	}



	ret = qmi_txn_wait(&txn, 5 * HZ);

	if (ret < 0)

		dev_err(sysmon->dev, "failed receiving QMI response\n");

		dev_err(sysmon->dev, "timeout waiting for subsystem event response\n");

	else if (resp.resp.result)

		dev_err(sysmon->dev, "ssr event send failed\n");

		dev_err(sysmon->dev, "subsystem event rejected\n");

	else

		dev_dbg(sysmon->dev, "ssr event send completed\n");

		dev_dbg(sysmon->dev, "subsystem event accepted\n");

}



/**