Commit 0aab29b8 authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Jens Axboe
Browse files

loop: remove extra variable in lo_fallocate() 



The local variable q is used to pass it to the blk_queue_discard(). We
can get away with using lo->lo_queue instead of storing in a local
variable which is not used anywhere else.

No functional change in this patch.

Signed-off-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Link: https://lore.kernel.org/r/20220215213310.7264-3-kch@nvidia.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent b27824d3

drivers/block/loop.c

+1 −2
Original line number Diff line number Diff line
@@ -308,12 +308,11 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos, 
	 * a.k.a. discard/zerorange.

	 */

	struct file *file = lo->lo_backing_file;

	struct request_queue *q = lo->lo_queue;

	int ret;



	mode |= FALLOC_FL_KEEP_SIZE;



	if (!blk_queue_discard(q)) {

	if (!blk_queue_discard(lo->lo_queue)) {

		ret = -EOPNOTSUPP;

		goto out;

	}