Commit 0aaa0b5f authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Miquel Raynal
Browse files

mtd: lpddr2_nvm: Warn about failure to unregister mtd device 



mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.

This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().

By returning 0 in the platform remove callback a generic error message
by the device core is suppressed, nothing else changes.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220603210758.148493-6-u.kleine-koenig@pengutronix.de
parent 90914b4e

drivers/mtd/lpddr/lpddr2_nvm.c

+3 −1
Original line number Diff line number Diff line
@@ -478,7 +478,9 @@ static int lpddr2_nvm_probe(struct platform_device *pdev) 
 */

static int lpddr2_nvm_remove(struct platform_device *pdev)

{

	return mtd_device_unregister(dev_get_drvdata(&pdev->dev));

	WARN_ON(mtd_device_unregister(dev_get_drvdata(&pdev->dev)));



	return 0;

}



/* Initialize platform_driver data structure for lpddr2_nvm */