Commit 0a97630a authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp: switch to explicit reset helpers 



Switch to consistently using the explicit reset-controller API which
makes it clear that the reset controllers are used exclusively by the
PHY driver.

Note that the deprecated of_reset_control_get() and
devm_reset_control_get() are just transitional wrappers for the explicit
API so there's no functional change.

Suggested-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220427063243.32576-4-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 4d2900f2

drivers/phy/qualcomm/phy-qcom-qmp.c

+2 −2
Original line number Diff line number Diff line
@@ -5587,7 +5587,7 @@ static int qcom_qmp_phy_reset_init(struct device *dev, const struct qmp_phy_cfg 
		struct reset_control *rst;

		const char *name = cfg->reset_list[i];



		rst = devm_reset_control_get(dev, name);

		rst = devm_reset_control_get_exclusive(dev, name);

		if (IS_ERR(rst)) {

			dev_err(dev, "failed to get %s reset\n", name);

			return PTR_ERR(rst);
@@ -5985,7 +5985,7 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id, 
	/* Get lane reset, if any */

	if (cfg->has_lane_rst) {

		snprintf(prop_name, sizeof(prop_name), "lane%d", id);

		qphy->lane_rst = of_reset_control_get(np, prop_name);

		qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name);

		if (IS_ERR(qphy->lane_rst)) {

			dev_err(dev, "failed to get lane%d reset\n", id);

			return PTR_ERR(qphy->lane_rst);