Commit 0a90ed8d authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Hans de Goede
Browse files

platform/x86: pmc_atom: Fix SLP_TYPx bitfield mask 



On Intel hardware the SLP_TYPx bitfield occupies bits 10-12 as per ACPI
specification (see Table 4.13 "PM1 Control Registers Fixed Hardware
Feature Control Bits" for the details).

Fix the mask and other related definitions accordingly.

Fixes: 93e5eadd ("x86/platform: New Intel Atom SOC power management controller driver")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220801113734.36131-1-andriy.shevchenko@linux.intel.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 568035b0

drivers/platform/x86/pmc_atom.c

+1 −1
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ static void pmc_power_off(void) 
	pm1_cnt_port = acpi_base_addr + PM1_CNT;



	pm1_cnt_value = inl(pm1_cnt_port);

	pm1_cnt_value &= SLEEP_TYPE_MASK;

	pm1_cnt_value &= ~SLEEP_TYPE_MASK;

	pm1_cnt_value |= SLEEP_TYPE_S5;

	pm1_cnt_value |= SLEEP_ENABLE;

include/linux/platform_data/x86/pmc_atom.h

+4 −2
Original line number Diff line number Diff line
@@ -7,6 +7,8 @@ 
#ifndef PMC_ATOM_H

#define PMC_ATOM_H



#include <linux/bits.h>



/* ValleyView Power Control Unit PCI Device ID */

#define	PCI_DEVICE_ID_VLV_PMC	0x0F1C

/* CherryTrail Power Control Unit PCI Device ID */
@@ -139,9 +141,9 @@ 
#define	ACPI_MMIO_REG_LEN	0x100



#define	PM1_CNT			0x4

#define	SLEEP_TYPE_MASK		0xFFFFECFF

#define	SLEEP_TYPE_MASK		GENMASK(12, 10)

#define	SLEEP_TYPE_S5		0x1C00

#define	SLEEP_ENABLE		0x2000

#define	SLEEP_ENABLE		BIT(13)



extern int pmc_atom_read(int offset, u32 *value);