Commit 0a298d13 authored by Dinghao Liu's avatar Dinghao Liu Committed by Jakub Kicinski
Browse files

net: qlcnic: add missed unlock in qlcnic_83xx_flash_read32 



qlcnic_83xx_unlock_flash() is called on all paths after we call
qlcnic_83xx_lock_flash(), except for one error path on failure
of QLCRD32(), which may cause a deadlock. This bug is suggested
by a static analysis tool, please advise.

Fixes: 81d0aeb0 ("qlcnic: flash template based firmware reset recovery")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20210816131405.24024-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 276e189f

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c

+3 −1
Original line number Diff line number Diff line
@@ -3156,8 +3156,10 @@ int qlcnic_83xx_flash_read32(struct qlcnic_adapter *adapter, u32 flash_addr, 


		indirect_addr = QLC_83XX_FLASH_DIRECT_DATA(addr);

		ret = QLCRD32(adapter, indirect_addr, &err);

		if (err == -EIO)

		if (err == -EIO) {

			qlcnic_83xx_unlock_flash(adapter);

			return err;

		}



		word = ret;

		*(u32 *)p_data  = word;