Commit 09fc1406 authored by Mario Limonciello's avatar Mario Limonciello Committed by Hans de Goede
Browse files

platform/x86: amd-pmc: only use callbacks for suspend 



This driver is intended to be used exclusively for suspend to idle
so callbacks to send OS_HINT during hibernate and S5 will set OS_HINT
at the wrong time leading to an undefined behavior.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20211210143529.10594-1-mario.limonciello@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 804034c4

drivers/platform/x86/amd-pmc.c

+2 −1
Original line number Diff line number Diff line
@@ -508,7 +508,8 @@ static int __maybe_unused amd_pmc_resume(struct device *dev) 
}



static const struct dev_pm_ops amd_pmc_pm_ops = {

	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume)

	.suspend_noirq = amd_pmc_suspend,

	.resume_noirq = amd_pmc_resume,

};



static const struct pci_device_id pmc_pci_ids[] = {