Commit 09edeb4c authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/radeon: Prefer pr_err/_info over printk 



Fixes the following checkpatch.pl:

WARNING: printk() should include KERN_<LEVEL> facility level

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5dbb5924

drivers/gpu/drm/radeon/radeon_atpx_handler.c

+6 −6
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ static union acpi_object *radeon_atpx_call(acpi_handle handle, int function, 


	/* Fail only if calling the method fails and ATPX is supported */

	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {

		printk("failed to evaluate ATPX got %s\n",

		pr_err("failed to evaluate ATPX got %s\n",

		       acpi_format_exception(status));

		kfree(buffer.pointer);

		return NULL;
@@ -171,7 +171,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx) 


		size = *(u16 *) info->buffer.pointer;

		if (size < 10) {

			printk("ATPX buffer is too small: %zu\n", size);

			pr_err("ATPX buffer is too small: %zu\n", size);

			kfree(info);

			return -EINVAL;

		}
@@ -202,7 +202,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx) 


	atpx->is_hybrid = false;

	if (valid_bits & ATPX_MS_HYBRID_GFX_SUPPORTED) {

		printk("ATPX Hybrid Graphics\n");

		pr_info("ATPX Hybrid Graphics\n");

		/*

		 * Disable legacy PM methods only when pcie port PM is usable,

		 * otherwise the device might fail to power off or power on.
@@ -239,7 +239,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx) 


	size = *(u16 *) info->buffer.pointer;

	if (size < 8) {

		printk("ATPX buffer is too small: %zu\n", size);

		pr_err("ATPX buffer is too small: %zu\n", size);

		err = -EINVAL;

		goto out;

	}
@@ -248,7 +248,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx) 
	memcpy(&output, info->buffer.pointer, size);



	/* TODO: check version? */

	printk("ATPX version %u, functions 0x%08x\n",

	pr_info("ATPX version %u, functions 0x%08x\n",

		output.version, output.function_bits);



	radeon_atpx_parse_functions(&atpx->functions, output.function_bits);