Commit 09ea9719 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: venus: venc: Fix potential null pointer dereference on pointer fmt 



Currently the call to find_format can potentially return a NULL to
fmt and the nullpointer is later dereferenced on the assignment of
pixmp->num_planes = fmt->num_planes.  Fix this by adding a NULL pointer
check and returning NULL for the failure case.

Addresses-Coverity: ("Dereference null return")

Fixes: aaaa93ed ("[media] media: venus: venc: add video encoder files")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarStanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 331e06bb

drivers/media/platform/qcom/venus/venc.c

+2 −0
Original line number Diff line number Diff line
@@ -183,6 +183,8 @@ venc_try_fmt_common(struct venus_inst *inst, struct v4l2_format *f) 
		else

			return NULL;

		fmt = find_format(inst, pixmp->pixelformat, f->type);

		if (!fmt)

			return NULL;

	}



	pixmp->width = clamp(pixmp->width, frame_width_min(inst),