Commit 09cab430 authored by Loic Poulain's avatar Loic Poulain Committed by Kalle Valo
Browse files

wcn36xx: Fix max channels retrieval 



Kernel test robot reported:drivers/net/wireless/ath/wcn36xx/smd.c:943:33:
   sparse: sparse: cast truncates bits from constant value (780 becomes 80)

The 'channels' field is not a simple u8 array but an array of
channel_params. Using sizeof for retrieving the max number of
channels is then wrong.

In practice, it was not an issue, because the sizeof returned
value is 780, which is truncated in min_t (u8) to 80, which is
the value we expect...

Fix that properly using ARRAY_SIZE instead of sizeof.

Fixes: d707f812 ("wcn36xx: Channel list update before hardware scan")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/1638435732-14657-1-git-send-email-loic.poulain@linaro.org
parent 9dcf6808

drivers/net/wireless/ath/wcn36xx/smd.c

+1 −1
Original line number Diff line number Diff line
@@ -944,7 +944,7 @@ int wcn36xx_smd_update_channel_list(struct wcn36xx *wcn, struct cfg80211_scan_re 


	INIT_HAL_MSG((*msg_body), WCN36XX_HAL_UPDATE_CHANNEL_LIST_REQ);



	msg_body->num_channel = min_t(u8, req->n_channels, sizeof(msg_body->channels));

	msg_body->num_channel = min_t(u8, req->n_channels, ARRAY_SIZE(msg_body->channels));

	for (i = 0; i < msg_body->num_channel; i++) {

		struct wcn36xx_hal_channel_param *param = &msg_body->channels[i];

		u32 min_power = WCN36XX_HAL_DEFAULT_MIN_POWER;