Commit 098abbd4 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Johannes Berg
Browse files

mac80211_hwsim: fix memory leak in hwsim_new_radio_nl 



When parse_pmsr_capa failed in hwsim_new_radio_nl, the memory resources
applied for by pmsr_capa are not released. Add release processing to the
incorrect path.

Fixes: 92d13386 ("mac80211_hwsim: add PMSR capability support")
Reported-by: default avatar <syzbot+904ce6fbb38532d9795c@syzkaller.appspotmail.com>
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230515092227.2691437-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent a8938bc8

drivers/net/wireless/virtual/mac80211_hwsim.c

+2 −1
Original line number Diff line number Diff line
@@ -5964,10 +5964,11 @@ static int hwsim_new_radio_nl(struct sk_buff *msg, struct genl_info *info) 
			ret = -ENOMEM;

			goto out_free;

		}

		param.pmsr_capa = pmsr_capa;



		ret = parse_pmsr_capa(info->attrs[HWSIM_ATTR_PMSR_SUPPORT], pmsr_capa, info);

		if (ret)

			goto out_free;

		param.pmsr_capa = pmsr_capa;

	}



	ret = mac80211_hwsim_new_radio(info, &param);