Commit 0972b8bf authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: improve TYPECAST_INT_CONSTANT test message 

Improve the TYPECAST_INT_CONSTANT test by showing the suggested conversion
for various type of uses like (unsigned int)1 to 1U.

Link: https://lkml.kernel.org/r/ecefe8dcb93fe7028311b69dd297ba52224233d4.camel@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent adb2da82

scripts/checkpatch.pl

+10 −10
Original line number Diff line number Diff line
@@ -6518,9 +6518,6 @@ sub process { 
		if ($line =~ /(\(\s*$C90_int_types\s*\)\s*)($Constant)\b/) {

			my $cast = $1;

			my $const = $2;

			if (WARN("TYPECAST_INT_CONSTANT",

				 "Unnecessary typecast of c90 int constant\n" . $herecurr) &&

			    $fix) {

			my $suffix = "";

			my $newconst = $const;

			$newconst =~ s/${Int_type}$//;
@@ -6530,6 +6527,9 @@ sub process { 
			} elsif ($cast =~ /\blong\b/) {

			    $suffix .= 'L';

			}

			if (WARN("TYPECAST_INT_CONSTANT",

				 "Unnecessary typecast of c90 int constant - '$cast$const' could be '$const$suffix'\n" . $herecurr) &&

			    $fix) {

				$fixed[$fixlinenr] =~ s/\Q$cast\E$const\b/$newconst$suffix/;

			}

		}