Commit 09700c50 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Daniel Lezcano
Browse files

thermal/drivers/imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe 



of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: e20db70d ("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220517055121.18092-1-linmq006@gmail.com


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 98a160e8

drivers/thermal/imx_sc_thermal.c

+4 −2
Original line number Diff line number Diff line
@@ -94,8 +94,8 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) 
		sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);

		if (!sensor) {

			of_node_put(child);

			of_node_put(sensor_np);

			return -ENOMEM;

			ret = -ENOMEM;

			goto put_node;

		}



		ret = thermal_zone_of_get_sensor_id(child,
@@ -124,7 +124,9 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) 
			dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n");

	}



put_node:

	of_node_put(sensor_np);

	of_node_put(np);



	return ret;

}