Commit 0969becb authored by Julian Wiedmann's avatar Julian Wiedmann Committed by David S. Miller
Browse files

s390/qeth: improve trace entries for MAC address (un)registration 



Add the failed MAC address into the trace message. Also fix up one
format string to use %x instead of %u for the CARD_DEVID.

Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: default avatarAlexandra Winter <wintera@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57bb1132

drivers/s390/net/qeth_l2_main.c

+6 −6
Original line number Diff line number Diff line
@@ -121,11 +121,11 @@ static int qeth_l2_write_mac(struct qeth_card *card, u8 *mac) 
	QETH_CARD_TEXT(card, 2, "L2Wmac");

	rc = qeth_l2_send_setdelmac(card, mac, cmd);

	if (rc == -EADDRINUSE)

		QETH_DBF_MESSAGE(2, "MAC already registered on device %x\n",

				 CARD_DEVID(card));

		QETH_DBF_MESSAGE(2, "MAC address %012llx is already registered on device %x\n",

				 ether_addr_to_u64(mac), CARD_DEVID(card));

	else if (rc)

		QETH_DBF_MESSAGE(2, "Failed to register MAC on device %x: %d\n",

				 CARD_DEVID(card), rc);

		QETH_DBF_MESSAGE(2, "Failed to register MAC address %012llx on device %x: %d\n",

				 ether_addr_to_u64(mac), CARD_DEVID(card), rc);

	return rc;

}
@@ -138,8 +138,8 @@ static int qeth_l2_remove_mac(struct qeth_card *card, u8 *mac) 
	QETH_CARD_TEXT(card, 2, "L2Rmac");

	rc = qeth_l2_send_setdelmac(card, mac, cmd);

	if (rc)

		QETH_DBF_MESSAGE(2, "Failed to delete MAC on device %u: %d\n",

				 CARD_DEVID(card), rc);

		QETH_DBF_MESSAGE(2, "Failed to delete MAC address %012llx on device %x: %d\n",

				 ether_addr_to_u64(mac), CARD_DEVID(card), rc);

	return rc;

}