Commit 096516d0 authored by Justin Chen's avatar Justin Chen Committed by Jakub Kicinski
Browse files

net: phy: broadcom: stub c45 read/write for 54810 



The 54810 does not support c45. The mmd_phy_indirect accesses return
arbirtary values leading to odd behavior like saying it supports EEE
when it doesn't. We also see that reading/writing these non-existent
MMD registers leads to phy instability in some cases.

Fixes: b14995ac ("net: phy: broadcom: Add BCM54810 PHY entry")
Signed-off-by: default avatarJustin Chen <justin.chen@broadcom.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/1691901708-28650-1-git-send-email-justin.chen@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e4dd0d3a

drivers/net/phy/broadcom.c

+13 −0
Original line number Diff line number Diff line
@@ -542,6 +542,17 @@ static int bcm54xx_resume(struct phy_device *phydev) 
	return bcm54xx_config_init(phydev);

}



static int bcm54810_read_mmd(struct phy_device *phydev, int devnum, u16 regnum)

{

	return -EOPNOTSUPP;

}



static int bcm54810_write_mmd(struct phy_device *phydev, int devnum, u16 regnum,

			      u16 val)

{

	return -EOPNOTSUPP;

}



static int bcm54811_config_init(struct phy_device *phydev)

{

	int err, reg;
@@ -1103,6 +1114,8 @@ static struct phy_driver broadcom_drivers[] = { 
	.get_strings	= bcm_phy_get_strings,

	.get_stats	= bcm54xx_get_stats,

	.probe		= bcm54xx_phy_probe,

	.read_mmd	= bcm54810_read_mmd,

	.write_mmd	= bcm54810_write_mmd,

	.config_init    = bcm54xx_config_init,

	.config_aneg    = bcm5481_config_aneg,

	.config_intr    = bcm_phy_config_intr,