Commit 095aabe3 authored by Ard Biesheuvel's avatar Ard Biesheuvel
Browse files

efi/libstub: zboot: Avoid eager evaluation of objcopy flags 



The Make variable containing the objcopy flags may be constructed from
the output of build tools operating on build artifacts, and these may
not exist when doing a make clean.

So avoid evaluating them eagerly, to prevent spurious build warnings.

Suggested-by: default avatarPedro Falcato <pedro.falcato@gmail.com>
Tested-by: default avatarAlan Bartlett <ajb@elrepo.org>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent ac9a7868

drivers/firmware/efi/libstub/Makefile.zboot

+2 −1
Original line number Diff line number Diff line
@@ -32,7 +32,8 @@ zboot-size-len-$(CONFIG_KERNEL_GZIP) := 0 
$(obj)/vmlinuz: $(obj)/vmlinux.bin FORCE

	$(call if_changed,$(zboot-method-y))



OBJCOPYFLAGS_vmlinuz.o := -I binary -O $(EFI_ZBOOT_BFD_TARGET) $(EFI_ZBOOT_OBJCOPY_FLAGS) \

# avoid eager evaluation to prevent references to non-existent build artifacts

OBJCOPYFLAGS_vmlinuz.o = -I binary -O $(EFI_ZBOOT_BFD_TARGET) $(EFI_ZBOOT_OBJCOPY_FLAGS) \

			  --rename-section .data=.gzdata,load,alloc,readonly,contents

$(obj)/vmlinuz.o: $(obj)/vmlinuz FORCE

	$(call if_changed,objcopy)