Commit 09564181 authored by Jesper Dangaard Brouer's avatar Jesper Dangaard Brouer Committed by Daniel Borkmann
Browse files

selftests/bpf: Fix check_mtu using wrong variable type 



Dan Carpenter found via Smatch static checker, that unsigned 'mtu_lo' is
never less than zero.

Variable mtu_lo should have been an 'int', because read_mtu_device_lo()
uses minus as error indications.

Fixes: b62eba56 ("selftests/bpf: Tests using bpf_check_mtu BPF-helper")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/bpf/168605104733.3636467.17945947801753092590.stgit@firesoul
parent aa618270

tools/testing/selftests/bpf/prog_tests/check_mtu.c

+1 −1
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ static void test_check_mtu_tc(__u32 mtu, __u32 ifindex) 


void serial_test_check_mtu(void)

{

	__u32 mtu_lo;

	int mtu_lo;



	if (test__start_subtest("bpf_check_mtu XDP-attach"))

		test_check_mtu_xdp_attach();