Commit 0944ea07 authored by Evan Benn's avatar Evan Benn Committed by Enric Balletbo i Serra
Browse files

platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT 



The host_event_code enum is 1-based, use EC_HOST_EVENT_MASK not BIT to
generate the intended mask. This patch changes the behaviour of the
mask, a following patch will restore the intended behaviour:
'Add LID and BATTERY to default mask'

Fixes: c214e564 ("platform/chrome: cros_ec_proto: ignore unnecessary wakeups on old ECs")
Signed-off-by: default avatarEvan Benn <evanbenn@chromium.org>
Reviewed-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20201209220306.1.I6133572c0ab3c6b95426f804bac2d3833e24acb1@changeid
parent 8553a979

drivers/platform/chrome/cros_ec_proto.c

+5 −5
Original line number Diff line number Diff line
@@ -526,11 +526,11 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev) 
		 * power), not wake up.

		 */

		ec_dev->host_event_wake_mask = U32_MAX &

			~(BIT(EC_HOST_EVENT_AC_DISCONNECTED) |

			  BIT(EC_HOST_EVENT_BATTERY_LOW) |

			  BIT(EC_HOST_EVENT_BATTERY_CRITICAL) |

			  BIT(EC_HOST_EVENT_PD_MCU) |

			  BIT(EC_HOST_EVENT_BATTERY_STATUS));

			~(EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |

			  EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_LOW) |

			  EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |

			  EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |

			  EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS));

		/*

		 * Old ECs may not support this command. Complain about all

		 * other errors.