Commit 09355d9d authored by Ritesh Harjani's avatar Ritesh Harjani Committed by Theodore Ts'o
Browse files

ext4: remove redundant max inline_size check in ext4_da_write_inline_data_begin() 



ext4_prepare_inline_data() already checks for ext4_get_max_inline_size()
and returns -ENOSPC. So there is no need to check it twice within
ext4_da_write_inline_data_begin(). This patch removes the extra check.

It also makes it more clean.

No functionality change in this patch.

Signed-off-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/cdd1654128d5105550c65fd13ca5da53b2162cc4.1642416995.git.riteshh@linux.ibm.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 897026aa

fs/ext4/inline.c

+4 −9
Original line number Diff line number Diff line
@@ -911,7 +911,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping, 
				    struct page **pagep,

				    void **fsdata)

{

	int ret, inline_size;

	int ret;

	handle_t *handle;

	struct page *page;

	struct ext4_iloc iloc;
@@ -928,14 +928,9 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping, 
		goto out;

	}



	inline_size = ext4_get_max_inline_size(inode);



	ret = -ENOSPC;

	if (inline_size >= pos + len) {

	ret = ext4_prepare_inline_data(handle, inode, pos + len);

	if (ret && ret != -ENOSPC)

		goto out_journal;

	}



	/*

	 * We cannot recurse into the filesystem as the transaction