Commit 0906f3a3 authored by Zheng Yongjun's avatar Zheng Yongjun Committed by David S. Miller
Browse files

net: sparx5: switchdev: fix possible NULL pointer dereference 



As the possible failure of the allocation, devm_kzalloc() may return NULL
pointer.
Therefore, it should be better to check the 'db' in order to prevent
the dereference of NULL pointer.

Fixes: 10615907 ("net: sparx5: switchdev: adding frame DMA functionality")
Signed-off-by: default avatarZheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 77816079

drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c

+2 −0
Original line number Diff line number Diff line
@@ -422,6 +422,8 @@ static int sparx5_fdma_tx_alloc(struct sparx5 *sparx5) 
			db_hw->dataptr = phys;

			db_hw->status = 0;

			db = devm_kzalloc(sparx5->dev, sizeof(*db), GFP_KERNEL);

			if (!db)

				return -ENOMEM;

			db->cpu_addr = cpu_addr;

			list_add_tail(&db->list, &tx->db_list);

		}