Commit 08fc7573 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Jakub Kicinski
Browse files

mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init 



The line cards array is not freed in the error path of
mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
freeing the array in the error path, thereby making the error path
identical to mlxsw_m_linecards_fini().

Fixes: 01328e23 ("mlxsw: minimal: Extend module to port mapping with slot index")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/20230630012647.1078002-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3cf62c81

drivers/net/ethernet/mellanox/mlxsw/minimal.c

+1 −0
Original line number Diff line number Diff line
@@ -417,6 +417,7 @@ static int mlxsw_m_linecards_init(struct mlxsw_m *mlxsw_m) 
err_kmalloc_array:

	for (i--; i >= 0; i--)

		kfree(mlxsw_m->line_cards[i]);

	kfree(mlxsw_m->line_cards);

err_kcalloc:

	kfree(mlxsw_m->ports);

	return err;