Commit 08a6caae authored by vulab's avatar vulab Committed by Dmitry Torokhov
Browse files

Input: cm109 - remove needless check before usb_free_coherent() 



usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: default avatarXu Wang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20200707030905.3123-1-vulab@iscas.ac.cn


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent deae5764

drivers/input/misc/cm109.c

+2 −6
Original line number Diff line number Diff line
@@ -663,12 +663,8 @@ static const struct usb_device_id cm109_usb_table[] = { 
static void cm109_usb_cleanup(struct cm109_dev *dev)

{

	kfree(dev->ctl_req);

	if (dev->ctl_data)

		usb_free_coherent(dev->udev, USB_PKT_LEN,

				  dev->ctl_data, dev->ctl_dma);

	if (dev->irq_data)

		usb_free_coherent(dev->udev, USB_PKT_LEN,

				  dev->irq_data, dev->irq_dma);

	usb_free_coherent(dev->udev, USB_PKT_LEN, dev->ctl_data, dev->ctl_dma);

	usb_free_coherent(dev->udev, USB_PKT_LEN, dev->irq_data, dev->irq_dma);



	usb_free_urb(dev->urb_irq);	/* parameter validation in core/urb */

	usb_free_urb(dev->urb_ctl);	/* parameter validation in core/urb */