Commit 08908fa1 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

usb: core: devices: drop redundant buffer overflow checks 



The USB device dump code often checks for the buffer overflow just before
calling the functions that do that first thing anyways.  Such checks are
redundant and may be dropped...

Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/0453cb0d-7b2b-25e6-50e3-091610951e58@omp.ru


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9c1c0fdd

drivers/usb/core/devices.c

+0 −12
Original line number Diff line number Diff line
@@ -228,8 +228,6 @@ static char *usb_dump_interface(int speed, char *start, char *end, 


	start = usb_dump_interface_descriptor(start, end, intfc, iface, setno);

	for (i = 0; i < desc->desc.bNumEndpoints; i++) {

		if (start > end)

			return start;

		start = usb_dump_endpoint_descriptor(speed,

				start, end, &desc->endpoint[i].desc);

	}
@@ -302,8 +300,6 @@ static char *usb_dump_config(int speed, char *start, char *end, 
		intfc = config->intf_cache[i];

		interface = config->interface[i];

		for (j = 0; j < intfc->num_altsetting; j++) {

			if (start > end)

				return start;

			start = usb_dump_interface(speed,

				start, end, intfc, interface, j);

		}
@@ -369,19 +365,11 @@ static char *usb_dump_desc(char *start, char *end, struct usb_device *dev) 
{

	int i;



	if (start > end)

		return start;



	start = usb_dump_device_descriptor(start, end, &dev->descriptor);



	if (start > end)

		return start;



	start = usb_dump_device_strings(start, end, dev);



	for (i = 0; i < dev->descriptor.bNumConfigurations; i++) {

		if (start > end)

			return start;

		start = usb_dump_config(dev->speed,

				start, end, dev->config + i,

				/* active ? */