Commit 0881ace2 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Linus Torvalds
Browse files

mm/mremap: use pmd/pud_poplulate to update page table entries 

pmd/pud_populate is the right interface to be used to set the respective
page table entries.  Some architectures like ppc64 do assume that
set_pmd/pud_at can only be used to set a hugepage PTE.  Since we are not
setting up a hugepage PTE here, use the pmd/pud_populate interface.

Link: https://lkml.kernel.org/r/20210616045239.370802-6-aneesh.kumar@linux.ibm.com


Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Hugh Dickins <hughd@google.com>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Kalesh Singh <kaleshsingh@google.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d6655dff

mm/mremap.c

+3 −4
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ 


#include <asm/cacheflush.h>

#include <asm/tlbflush.h>

#include <asm/pgalloc.h>



#include "internal.h"
@@ -258,8 +259,7 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr, 


	VM_BUG_ON(!pmd_none(*new_pmd));



	/* Set the new pmd */

	set_pmd_at(mm, new_addr, new_pmd, pmd);

	pmd_populate(mm, new_pmd, pmd_pgtable(pmd));

	flush_tlb_range(vma, old_addr, old_addr + PMD_SIZE);

	if (new_ptl != old_ptl)

		spin_unlock(new_ptl);
@@ -306,8 +306,7 @@ static bool move_normal_pud(struct vm_area_struct *vma, unsigned long old_addr, 


	VM_BUG_ON(!pud_none(*new_pud));



	/* Set the new pud */

	set_pud_at(mm, new_addr, new_pud, pud);

	pud_populate(mm, new_pud, pud_pgtable(pud));

	flush_tlb_range(vma, old_addr, old_addr + PUD_SIZE);

	if (new_ptl != old_ptl)

		spin_unlock(new_ptl);