Unverified Commit 087e3900 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mark Brown
Browse files

ASoC: fsl_easrc: mark PM functions __maybe_unused 



ifdefs are hard, and in this driver the suspend/resume functions are
the only callers of some other helpers that trigger a harmless warning
when CONFIG_PM is disabled:

sound/soc/fsl/fsl_easrc.c:1807:12: warning: 'fsl_easrc_get_firmware' defined but not used [-Wunused-function]
 1807 | static int fsl_easrc_get_firmware(struct fsl_asrc *easrc)
      |            ^~~~~~~~~~~~~~~~~~~~~~
sound/soc/fsl/fsl_easrc.c:303:12: warning: 'fsl_easrc_resampler_config' defined but not used [-Wunused-function]
  303 | static int fsl_easrc_resampler_config(struct fsl_asrc *easrc)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~

Remove the #ifdef and just mark the callers as __maybe_unused to
suppress the warnings altogether.

Fixes: 955ac624 ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
Link: https://lore.kernel.org/r/20200428212847.2926376-1-arnd@arndb.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent da33574f

sound/soc/fsl/fsl_easrc.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -1997,8 +1997,7 @@ static int fsl_easrc_remove(struct platform_device *pdev) 
	return 0;

	return 0;

}

}





#ifdef CONFIG_PM

static __maybe_unused int fsl_easrc_runtime_suspend(struct device *dev)

static int fsl_easrc_runtime_suspend(struct device *dev)

{

{

	struct fsl_asrc *easrc = dev_get_drvdata(dev);

	struct fsl_asrc *easrc = dev_get_drvdata(dev);

	struct fsl_easrc_priv *easrc_priv = easrc->private;

	struct fsl_easrc_priv *easrc_priv = easrc->private;
@@ -2015,7 +2014,7 @@ static int fsl_easrc_runtime_suspend(struct device *dev) 
	return 0;

	return 0;

}

}





static int fsl_easrc_runtime_resume(struct device *dev)

static __maybe_unused int fsl_easrc_runtime_resume(struct device *dev)

{

{

	struct fsl_asrc *easrc = dev_get_drvdata(dev);

	struct fsl_asrc *easrc = dev_get_drvdata(dev);

	struct fsl_easrc_priv *easrc_priv = easrc->private;

	struct fsl_easrc_priv *easrc_priv = easrc->private;
@@ -2094,7 +2093,6 @@ static int fsl_easrc_runtime_resume(struct device *dev) 
	clk_disable_unprepare(easrc->mem_clk);

	clk_disable_unprepare(easrc->mem_clk);

	return ret;

	return ret;

}

}

#endif /* CONFIG_PM */





static const struct dev_pm_ops fsl_easrc_pm_ops = {

static const struct dev_pm_ops fsl_easrc_pm_ops = {

	SET_RUNTIME_PM_OPS(fsl_easrc_runtime_suspend,

	SET_RUNTIME_PM_OPS(fsl_easrc_runtime_suspend,