Commit 0872774d authored by Alan's avatar Alan Committed by Martin K. Petersen
Browse files

lpfc: fix missing zero termination in debugfs 



If you feed 32 bytes in then the kstrtoull() doesn't receive a terminated
string so will run off the end.

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5b2e0c1b

drivers/scsi/lpfc/lpfc_debugfs.c

+2 −2
Original line number Diff line number Diff line
@@ -1054,11 +1054,11 @@ lpfc_debugfs_dif_err_write(struct file *file, const char __user *buf, 
{

	struct dentry *dent = file->f_path.dentry;

	struct lpfc_hba *phba = file->private_data;

	char dstbuf[32];

	char dstbuf[33];

	uint64_t tmp = 0;

	int size;



	memset(dstbuf, 0, 32);

	memset(dstbuf, 0, 33);

	size = (nbytes < 32) ? nbytes : 32;

	if (copy_from_user(dstbuf, buf, size))

		return 0;