Commit 0868b1ce authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Add enabledisable() 



'enable ? "enable" : "disable"' is a fairly common pattern in
our debug prints. Let's introduce a helper for it.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210416171011.19012-8-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent b88da660

drivers/gpu/drm/i915/display/intel_ddi.c

+2 −2
Original line number Diff line number Diff line
@@ -2334,8 +2334,8 @@ static void intel_dp_sink_set_msa_timing_par_ignore_state(struct intel_dp *intel 
	if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_DOWNSPREAD_CTRL,

			       enable ? DP_MSA_TIMING_PAR_IGNORE_EN : 0) <= 0)

		drm_dbg_kms(&i915->drm,

			    "Failed to set MSA_TIMING_PAR_IGNORE %s in the sink\n",

			    enable ? "enable" : "disable");

			    "Failed to %s MSA_TIMING_PAR_IGNORE in the sink\n",

			    enabledisable(enable));

}



static void intel_dp_sink_set_fec_ready(struct intel_dp *intel_dp,

drivers/gpu/drm/i915/display/intel_display_power.c

+1 −1
Original line number Diff line number Diff line
@@ -4766,7 +4766,7 @@ static void gen9_dbuf_slice_set(struct drm_i915_private *dev_priv, 
	state = intel_de_read(dev_priv, reg) & DBUF_POWER_STATE;

	drm_WARN(&dev_priv->drm, enable != state,

		 "DBuf slice %d power %s timeout!\n",

		 slice, enable ? "enable" : "disable");

		 slice, enabledisable(enable));

}



void gen9_dbuf_slices_update(struct drm_i915_private *dev_priv,

drivers/gpu/drm/i915/display/intel_dp.c

+1 −1
Original line number Diff line number Diff line
@@ -1861,7 +1861,7 @@ void intel_dp_sink_set_decompression_state(struct intel_dp *intel_dp, 
	if (ret < 0)

		drm_dbg_kms(&i915->drm,

			    "Failed to %s sink decompression state\n",

			    enable ? "enable" : "disable");

			    enabledisable(enable));

}



static void

drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c

+1 −1
Original line number Diff line number Diff line
@@ -291,7 +291,7 @@ static void set_vesa_backlight_enable(struct intel_dp *intel_dp, bool enable) 
	if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER,

			       reg_val) != 1) {

		drm_dbg_kms(&i915->drm, "Failed to %s aux backlight\n",

			    enable ? "enable" : "disable");

			    enabledisable(enable));

	}

}

drivers/gpu/drm/i915/i915_utils.h

+5 −0
Original line number Diff line number Diff line
@@ -418,6 +418,11 @@ static inline const char *onoff(bool v) 
	return v ? "on" : "off";

}



static inline const char *enabledisable(bool v)

{

	return v ? "enable" : "disable";

}



static inline const char *enableddisabled(bool v)

{

	return v ? "enabled" : "disabled";