Commit 085aa2de authored by Arvind Yadav's avatar Arvind Yadav Committed by Greg Kroah-Hartman
Browse files

mm: memory_hotplug: use put_device() if device_register fail 



if device_register() returned an error. Always use put_device()
to give up the initialized reference and release allocated memory.

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 13509860

drivers/base/memory.c

+7 −1
Original line number Diff line number Diff line
@@ -649,13 +649,19 @@ static const struct attribute_group *memory_memblk_attr_groups[] = { 
static

int register_memory(struct memory_block *memory)

{

	int ret;



	memory->dev.bus = &memory_subsys;

	memory->dev.id = memory->start_section_nr / sections_per_block;

	memory->dev.release = memory_block_release;

	memory->dev.groups = memory_memblk_attr_groups;

	memory->dev.offline = memory->state == MEM_OFFLINE;



	return device_register(&memory->dev);

	ret = device_register(&memory->dev);

	if (ret)

		put_device(&memory->dev);



	return ret;

}



static int init_memory_block(struct memory_block **memory,