Commit 08469dac authored by Jie Wang's avatar Jie Wang Committed by Jakub Kicinski
Browse files

net: hns3: refactor hclge_mac_link_status_wait for interface reuse 



Some nic configurations could only be performed after link is down. So this
patch refactor this API for reuse.

Signed-off-by: default avatarJie Wang <wangjie125@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20230807113452.474224-3-shaojijie@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 15159ec0

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+9 −5
Original line number Diff line number Diff line
@@ -72,6 +72,8 @@ static void hclge_restore_hw_table(struct hclge_dev *hdev); 
static void hclge_sync_promisc_mode(struct hclge_dev *hdev);

static void hclge_sync_fd_table(struct hclge_dev *hdev);

static void hclge_update_fec_stats(struct hclge_dev *hdev);

static int hclge_mac_link_status_wait(struct hclge_dev *hdev, int link_ret,

				      int wait_cnt);



static struct hnae3_ae_algo ae_algo;
@@ -7647,10 +7649,9 @@ static void hclge_phy_link_status_wait(struct hclge_dev *hdev, 
	} while (++i < HCLGE_PHY_LINK_STATUS_NUM);

}



static int hclge_mac_link_status_wait(struct hclge_dev *hdev, int link_ret)

static int hclge_mac_link_status_wait(struct hclge_dev *hdev, int link_ret,

				      int wait_cnt)

{

#define HCLGE_MAC_LINK_STATUS_NUM  100



	int link_status;

	int i = 0;

	int ret;
@@ -7663,13 +7664,15 @@ static int hclge_mac_link_status_wait(struct hclge_dev *hdev, int link_ret) 
			return 0;



		msleep(HCLGE_LINK_STATUS_MS);

	} while (++i < HCLGE_MAC_LINK_STATUS_NUM);

	} while (++i < wait_cnt);

	return -EBUSY;

}



static int hclge_mac_phy_link_status_wait(struct hclge_dev *hdev, bool en,

					  bool is_phy)

{

#define HCLGE_MAC_LINK_STATUS_NUM  100



	int link_ret;



	link_ret = en ? HCLGE_LINK_STATUS_UP : HCLGE_LINK_STATUS_DOWN;
@@ -7677,7 +7680,8 @@ static int hclge_mac_phy_link_status_wait(struct hclge_dev *hdev, bool en, 
	if (is_phy)

		hclge_phy_link_status_wait(hdev, link_ret);



	return hclge_mac_link_status_wait(hdev, link_ret);

	return hclge_mac_link_status_wait(hdev, link_ret,

					  HCLGE_MAC_LINK_STATUS_NUM);

}



static int hclge_set_app_loopback(struct hclge_dev *hdev, bool en)